add tests & refactor tx crate #3835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/refactor-tx
branch
from
4a474a6
to
5e283f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3835 +/- ##
==========================================
+ Coverage 72.82% 73.00% +0.18%
==========================================
Files 338 339 +1
Lines 104220 104637 +417
==========================================
+ Hits 75897 76393 +496
+ Misses 28323 28244 -79 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/refactor-tx
branch
from
5e283f6
to
98be5f3
Compare
tzemanovic
force-pushed
the
tomas/refactor-tx
branch
from
98be5f3
to
9842883
Compare
grarco
reviewed
Sep 24, 2024
| } | ||
|
|
||
| // Set inner tx data | ||
| let data_bytes = "bingbong".as_bytes(); |
grarco
reviewed
Sep 24, 2024
| #[derive(Debug, Clone)] | ||
| pub enum InnerTxRef<'a> { | ||
| /// A direct ref to tx commitments | ||
| Commitment(&'a TxCommitments), |
There was a problem hiding this comment.
If this was an owned value instead of a ref we could use InnerTx inside both BatchedTx and BatchedTxRef in place of TxCommitments but this would imply many more changes and those two struct are only used within the protocol, don't know if you have a strong opinion on this
|
Also there are a few functions in namada/crates/tx/src/data/mod.rs Line 172 in 760462b I think we can use the new |
tzemanovic
added a commit
that referenced
this pull request
Oct 2, 2024
3 tasks
tzemanovic
added a commit
that referenced
this pull request
Oct 2, 2024
|
closing in favor of #3868 |
tzemanovic
added a commit
that referenced
this pull request
Oct 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
(cherry picked from commit 02eca6e)
3 tasks
tzemanovic
added a commit
that referenced
this pull request
Oct 3, 2024
* mergify/bp/0.44.0/pr-3868: changelog: add #3835 tx: test tx sections api tx: improve the serialization api test/tx: add more unit tests tx: split out tx sections into dedicated mod tx: move signing related code into sign mod tx: rm unsued `SignedTxData` refactor and test signature index tx/types: rm unused code test/e2e: no dbg logs in shielded sync
tzemanovic
added a commit
that referenced
this pull request
Oct 11, 2024
* 0.44.0: Namada 0.44.1 Removes old reference to encrypted txs test/e2e/ibc: try to kill gaiad before running it Fixes broken assertions in integration tests Update crates/sdk/src/queries/vp/pos.rs small fix from comments changelog: add #3899 fix up liveness queries Add new rpc query function to check validators' liveness(uptime) in this epoch test/e2e: try to forward Ctrl+C to the bg session Changelog for #3860 feat: serde rename batch index into masp tx index Tries to drop bg process in tests mergify: unquote base branch name Changelog #3882 Extends batch sections test to check duplicate sections Custom `PartialEq` impl for `SigningTxData` Fixes cmt reference in `add_inner_tx` Avoids duplicated sections when contructing a batch ci/mergify: unquote base name Increases timeout on epoch sleep Improves epoch sleeping in ibc tests and renames token variable Changelog #3866 Sped up ibc token test Fixes ibc gas payment test Fixes typos and updates docstring e2e test for ibc token gas payment goveranance: let validator vote even if it doesn't have a self-bond changelog: add #3835 tx: test tx sections api tx: improve the serialization api test/tx: add more unit tests tx: split out tx sections into dedicated mod tx: move signing related code into sign mod tx: rm unsued `SignedTxData` refactor and test signature index tx/types: rm unused code test/e2e: no dbg logs in shielded sync ci/mergify: add merge rule for backport to 0.44 mergify: add backport strategy Changelog #3857 Removes unused `Success` event Adds test for identical events in batch Adds batch events tests Removes eprintln from prepare proposal unit tests Adds tests for whitelisted tokens gas payment update hermes test/e2e: increase hermes timeout README: add notes about hermes update hermes ci: run checks on release branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
related to #1497
closes #3200
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo